Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print more startup information #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martijnarts
Copy link
Contributor

I'm not sure how you feel about reporting from hook libraries, so feel free to turn this one down. Just added it since this helped me a lot with debugging the last few issues.

It might be useful instead to use logging and accept an additional --level argument from Dredd, to keep the same (or a similar) log level across Dredd and its hooks?

@w-vi
Copy link
Member

w-vi commented Mar 21, 2017

Yeah, I've done this too but never pushed the code. I might make sense to have a general Dredd flag like --debug or --verbose for all hook handlers so you can request detailed logging form the handler. It is very useful when debugging hook file issues but once hooks are in place it just clutters the output. @honzajavorek What do you think?

@honzajavorek
Copy link
Contributor

I think it is a good idea in general, but if it's something to be supported widely in Dredd, it needs to go through https://github.com/apiaryio/dredd-hooks-template, preferably tested first :)

There are some changes going on which are basically trying to change hook handlers in a way Dredd could pass options to them (not only a list of files), so once that is sorted out, I think it will be very simple to add one more useful option to the mix. However, until that underlying work is done, I would wait with this.

Still, the time can be used for writing tests for the test suite in the https://github.com/apiaryio/dredd-hooks-template and polishing details on how this should work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants