chore(frontend): uplift Cypress to v13 #29265
Conversation
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
uplift-cypress-to-v13
branch
from
edad0b3
to
c737052
Compare
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
uplift-cypress-to-v13
branch
from
c737052
to
e323cb9
Compare
Signed-off-by: hainenber <[email protected]>
|
Hey, thanks for getting into this! This'll enable some cool stuff, including test playback on the Cypress dashboard, which is pretty nifty! |
The coordinates to drill the BarChartV2 are much harder due to slender visualization so we have to increase the `y` coordinate to get more chance clicking into correct areas. This in turns forces the test assertion to be more laxed to handle many states the drill-by can have. Signed-off-by: hainenber <[email protected]>
… v13 Signed-off-by: hainenber <[email protected]>
… to v13 Signed-off-by: hainenber <[email protected]>
| [70, 94], | ||
| [362, 68], | ||
| ]); | ||
| [362, 474], |
There was a problem hiding this comment.
I'm not sure if it's due to Cypress upgrade or else but the previous coordinates were flaky. I have to manually tinker around to pick out the least "flaky" coordinates to pass local CI
| @@ -588,7 +719,7 @@ describe('Drill by modal', () => { | |||
| it('Gauge Chart', () => { | |||
| testEchart('gauge_chart', 'Gauge Chart', [ | |||
| [151, 95], | |||
| [300, 143], | |||
| [300, NaN], // this fixes the test after upgrading to Cypress 13 | |||
There was a problem hiding this comment.
This is completely voodoo magic to me. Previous coordinates didn't work and frustratingly I entered NaN and it worked
|
|
||
| // reload dashboard | ||
| cy.reload(); | ||
| cy.get(dataTestChartName(testItems.topTenChart.name)).within(() => { | ||
| cy.contains(testItems.filterDefaultValue).should('be.visible'); | ||
| cy.contains(testItems.filterOtherCountry).should('not.exist'); |
There was a problem hiding this comment.
cy.reload() in Cypress 13 seems to completely remove local cache for stored filter inputs. Lmk if my change here is a fix or a band-aid :D
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
This reverts commit db4985a.
…ativeFilters` test Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
uplift-cypress-to-v13
branch
from
a711ca3
to
6bbb7ac
Compare
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
| @@ -37,30 +36,10 @@ export default eyesPlugin( | |||
| openMode: 0, | |||
| }, | |||
| e2e: { | |||
| experimentalMemoryManagement: true, | |||
There was a problem hiding this comment.
I see we are doing { testIsolation: false } in the describe blocks, is there a reason to not just add that to the config instead?
There was a problem hiding this comment.
It's due to default test isolation in Cypress 12. While there are many tests sharing context, as evidenced by the amount of { testIsolation: false }, the remaining are isolated and should be encouraged instead.
We'll probably need to refactor these context-sharing tests later to be isolated in future PRs.
Signed-off-by: hainenber <[email protected]>
chore(frontend): uplift Cypress to v13
SUMMARY
Uplift Cypress to currency (v13). Acceptance threshold is all Cypress tests in CI pass with flying colors :D
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION