-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add connector for CouchbaseDB #29225
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29225 +/- ##
===========================================
+ Coverage 60.48% 83.74% +23.25%
===========================================
Files 1931 519 -1412
Lines 76236 37685 -38551
Branches 8568 0 -8568
===========================================
- Hits 46114 31559 -14555
+ Misses 28017 6126 -21891
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Any | ||
) | ||
|
||
class CouchbaseEngineSpec(BaseEngineSpec): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can you add BasicParametersMixin
to this since using MYSQL dialect
https://github.com/apache/superset/blob/master/superset/db_engine_specs/base.py#L2276
Thanks @ayush33143314 for adding the engine. Would you also mind:
|
Thank you for this! Would it also be possible to add a docs entry here? |
Hi , yes, I am preparing the doc, I will submit doc along with tests in next patchset. Sorry for this patch. It is still in progress. |
Ahh, ok, thanks! Feel free to add [WIP] to the title and/or convert it to a draft PR if you need a while to keep working on it, just so others don't assume it's ready for review like I did. Thanks again! |
SUMMARY
Add support for couchbase db. https://www.couchbase.com/products/analytics/
TESTING INSTRUCTIONS
mannual Testing
ADDITIONAL INFORMATION