Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connector for CouchbaseDB #29225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ayush33143314
Copy link

SUMMARY

Add support for couchbase db. https://www.couchbase.com/products/analytics/

TESTING INSTRUCTIONS

mannual Testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added data:connect Namespace | Anything related to db connections / integrations enhancement:db Suggest new DB connections labels Jun 12, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 79.03226% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (76d897e) to head (fae8eb9).
Report is 356 commits behind head on master.

Files Patch % Lines
superset/db_engine_specs/couchbase.py 79.03% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29225       +/-   ##
===========================================
+ Coverage   60.48%   83.74%   +23.25%     
===========================================
  Files        1931      519     -1412     
  Lines       76236    37685    -38551     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31559    -14555     
+ Misses      28017     6126    -21891     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.95% <79.03%> (-0.21%) ⬇️
javascript ?
mysql 77.29% <79.03%> (?)
postgres 77.40% <79.03%> (?)
presto 53.55% <79.03%> (-0.26%) ⬇️
python 83.74% <79.03%> (+20.25%) ⬆️
sqlite 76.86% <79.03%> (?)
unit 59.24% <79.03%> (+1.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Any
)

class CouchbaseEngineSpec(BaseEngineSpec):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can you add BasicParametersMixin to this since using MYSQL dialect
https://github.com/apache/superset/blob/master/superset/db_engine_specs/base.py#L2276

@john-bodley
Copy link
Member

Thanks @ayush33143314 for adding the engine. Would you also mind:

  • Adding unit/integration tests (where necessary)
  • Updating the various documentation which outlines which engines we support etc.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 24, 2024
@rusackas
Copy link
Member

Thank you for this! Would it also be possible to add a docs entry here?

@ayush-couchbase
Copy link

Thank you for this! Would it also be possible to add a docs entry here?

Hi , yes, I am preparing the doc, I will submit doc along with tests in next patchset. Sorry for this patch. It is still in progress.

@rusackas
Copy link
Member

Ahh, ok, thanks! Feel free to add [WIP] to the title and/or convert it to a draft PR if you need a while to keep working on it, just so others don't assume it's ready for review like I did. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect:couchdb data:connect Namespace | Anything related to db connections / integrations enhancement:db Suggest new DB connections size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants