-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): enable tab selection for dashboard alerts/reports #29096
Draft
fisjac
wants to merge
4
commits into
apache:master
Choose a base branch
from
fisjac:ar-tabs/tree-select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
alert-reports
Namespace | Anything related to the Alert & Reports feature
dashboard
Namespace | Anything related to the Dashboard
labels
Jun 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29096 +/- ##
==========================================
+ Coverage 60.48% 61.19% +0.70%
==========================================
Files 1931 1956 +25
Lines 76236 78396 +2160
Branches 8568 8951 +383
==========================================
+ Hits 46114 47977 +1863
- Misses 28017 28225 +208
- Partials 2105 2194 +89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
added
review:checkpoint
Last PR reviewed during the daily review standup
review:draft
and removed
review:checkpoint
Last PR reviewed during the daily review standup
labels
Jun 5, 2024
fisjac
force-pushed
the
ar-tabs/tree-select
branch
from
June 14, 2024 16:30
7984f28
to
43a0fa6
Compare
fisjac
force-pushed
the
ar-tabs/tree-select
branch
2 times, most recently
from
June 25, 2024 17:04
0361493
to
0cbe1ac
Compare
fisjac
force-pushed
the
ar-tabs/tree-select
branch
from
June 25, 2024 17:27
ebf1fdd
to
9cf1063
Compare
fisjac
force-pushed
the
ar-tabs/tree-select
branch
from
June 25, 2024 17:33
9cf1063
to
9860098
Compare
fisjac
force-pushed
the
ar-tabs/tree-select
branch
from
June 25, 2024 17:42
9860098
to
a86e642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alert-reports
Namespace | Anything related to the Alert & Reports feature
dashboard
Namespace | Anything related to the Dashboard
dependencies:npm
review:draft
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implements a new feature enabling a tab to be selected as a view for an alert/report. When a dashboard is selected as the content for a report, an antd TreeSelect component is rendered to load and select tab options. When selected, the tab selection is added to the report payload as an anchor.
On execution, the feature takes advantage of existing logic for the report.extra.dashboard.anchor_tab attribute of the ReportSchedule SQLA model. When extra metadata are attached to the report schedule, a permalink is generated with the metadata included, and this permalink is then used to generate screenshots of the selected dashboard.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION