Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): enable tab selection for dashboard alerts/reports #29096

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented Jun 5, 2024

SUMMARY

Implements a new feature enabling a tab to be selected as a view for an alert/report. When a dashboard is selected as the content for a report, an antd TreeSelect component is rendered to load and select tab options. When selected, the tab selection is added to the report payload as an anchor.

On execution, the feature takes advantage of existing logic for the report.extra.dashboard.anchor_tab attribute of the ReportSchedule SQLA model. When extra metadata are attached to the report schedule, a permalink is generated with the metadata included, and this permalink is then used to generate screenshots of the selected dashboard.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: ALERT_REPORTS, ALERT_REPORT_TABS
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added api Related to the REST API dependencies:npm labels Jun 5, 2024
@dosubot dosubot bot added alert-reports Namespace | Anything related to the Alert & Reports feature dashboard Namespace | Anything related to the Dashboard labels Jun 5, 2024
@fisjac fisjac marked this pull request as draft June 5, 2024 16:45
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 61.19%. Comparing base (76d897e) to head (a86e642).
Report is 364 commits behind head on master.

Files Patch % Lines
...-frontend/src/features/alerts/AlertReportModal.tsx 57.14% 9 Missing ⚠️
...rontend/src/dashboard/containers/DashboardPage.tsx 0.00% 1 Missing ⚠️
superset/commands/report/execute.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29096      +/-   ##
==========================================
+ Coverage   60.48%   61.19%   +0.70%     
==========================================
  Files        1931     1956      +25     
  Lines       76236    78396    +2160     
  Branches     8568     8951     +383     
==========================================
+ Hits        46114    47977    +1863     
- Misses      28017    28225     +208     
- Partials     2105     2194      +89     
Flag Coverage Δ
hive 48.90% <50.00%> (-0.26%) ⬇️
javascript 58.01% <54.54%> (+0.29%) ⬆️
presto 53.51% <50.00%> (-0.30%) ⬇️
python 64.65% <50.00%> (+1.16%) ⬆️
unit 59.20% <50.00%> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley added review:checkpoint Last PR reviewed during the daily review standup review:draft and removed review:checkpoint Last PR reviewed during the daily review standup labels Jun 5, 2024
@geido geido requested review from kgabryje and geido June 10, 2024 16:18
@fisjac fisjac force-pushed the ar-tabs/tree-select branch 2 times, most recently from 0361493 to 0cbe1ac Compare June 25, 2024 17:04
@github-actions github-actions bot removed the api Related to the REST API label Jun 25, 2024
@github-actions github-actions bot added the api Related to the REST API label Jun 25, 2024
@github-actions github-actions bot removed the api Related to the REST API label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature dashboard Namespace | Anything related to the Dashboard dependencies:npm review:draft size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants