Remove useless OnlineDatabaseConnectionManager and AnalyzeDatabaseConnectionManager, add databaseName parameter in getConnections method #31699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nectionManager, add databaseName parameter in getConnections method
FlyingZC
approved these changes
Jun 17, 2024
taojintianxia
pushed a commit
to taojintianxia/shardingsphere
that referenced
this pull request
Jun 21, 2024
…nectionManager, add databaseName parameter in getConnections method (apache#31699) * Remove useless OnlineDatabaseConnectionManager and AnalyzeDatabaseConnectionManager, add databaseName parameter in getConnections method * revert it-env.props * optimize code style * refactor getConnections logic * refactor getConnections logic * fix checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.