Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple sql-federation-core in sharding and broadcast module, and refactor sql federation logic #31698

Merged
merged 15 commits into from
Jun 18, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Jun 14, 2024

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Decouple sql-federation-core in sharding and broadcast module, and refactor sql federation logic

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu
Copy link
Member Author

image

@strongduanmu strongduanmu marked this pull request as ready for review June 17, 2024 23:46
@strongduanmu
Copy link
Member Author

image

@FlyingZC FlyingZC merged commit bb52b25 into apache:master Jun 18, 2024
141 checks passed
@strongduanmu strongduanmu deleted the dev-0614 branch June 18, 2024 01:15
@iamhucong iamhucong self-requested a review June 18, 2024 01:22
iamhucong

This comment was marked as resolved.

taojintianxia pushed a commit to taojintianxia/shardingsphere that referenced this pull request Jun 21, 2024
…factor sql federation logic (apache#31698)

* Decouple sql-federation-core in sharding and broadcast module, and refactor sql federation logic

* remove useless route logic

* remove useless route logic

* remove sql federation rule

* fix unit test

* fix build error

* comment sql federation view e2e test case

* comment sql federation view e2e test case

* fix unit test

* fix unit test

* optimize sql federation decide logic for system table

* fix unit test

* fix checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants