Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Connector-V2] Support schema evolution for mysql-cdc and mysql-jdbc #6929

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

[Improve][Connector-V2] Support schema evolution for mysql-cdc and mysql-jdbc #6929

wants to merge 9 commits into from
+2,517 −45

Conversation

dailai
Copy link
Contributor

@dailai dailai commented May 31, 2024 •
edited
Loading

Purpose of this pull request

  1. Support schema evolution for mysql-cdc
  • Support add column
  • Support drop column
  • Support modify data type of column
  • Support rename name of column
  1. Support schema evolution for mysql jdbc sink
  • Support add column
  • Support drop column
  • Support modify data type of column
  • Support rename name of column

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0 hailin0 mentioned this pull request May 31, 2024
Open
3 tasks
@hailin0
Copy link
Member

hailin0 commented May 31, 2024

subtask of #4672

@steveGuRen
Copy link

中文：
这块是否有方案文档，对这块有兴趣，想了解一下是如何实现点的，想看看能不能实现动态加表的特性，如果可以，想看看我能不能实现
English：
Is there a solution document for this? I am interested in this and would like to understand how it is implemented. I want to see if it is possible to achieve the feature of dynamically adding tables. If so, I would like to see if I can implement it.

@dailai dailai force-pushed the schema-evolution branch 2 times, most recently from e7930b0 to 920f3d7 Compare June 12, 2024 02:42
@dailai dailai changed the title [Improve][Connector-V2] Support schema evolution for mysql-cdc [Improve][Connector-V2] Support schema evolution for mysql-cdc and mysql-jdbc Jun 12, 2024
@dailai dailai mentioned this pull request Jun 13, 2024
Merged
4 tasks
@dailai dailai force-pushed the schema-evolution branch 3 times, most recently from a4b7280 to dc9cbed Compare June 14, 2024 00:36
@dailai dailai mentioned this pull request Jun 17, 2024
Closed
3 tasks
This was referenced Jun 17, 2024
Merged
Closed
@Carl-Zhou-CN
Copy link
Member

Has it already been completed?

@dailai
Copy link
Contributor Author

dailai commented Jun 20, 2024

Has it already been completed?

Yes, I have tested both locally and using e2e several times.

@dailai dailai requested a review from hailin0 June 25, 2024 00:52
@hailin0
Copy link
Member

hailin0 commented Jun 25, 2024

cc @EricJoy2048 @Hisoka-X

@Carl-Zhou-CN
Copy link
Member

Carl-Zhou-CN commented Jun 26, 2024 •
edited
Loading

Has it already been completed?

Yes, I have tested both locally and using e2e several times.

ok

@dailai dailai requested a review from Carl-Zhou-CN June 27, 2024 08:37
Carl-Zhou-CN
Carl-Zhou-CN approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carl-Zhou-CN Carl-Zhou-CN Carl-Zhou-CN approved these changes

@hailin0 hailin0 Awaiting requested review from hailin0

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
approved cdc mysql reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dailai @hailin0 @steveGuRen @Carl-Zhou-CN