Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Use a version catalog #648

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Conversation

dtrunk90
Copy link
Contributor

@dtrunk90 dtrunk90 commented Jun 30, 2023

Using a version catalog makes things easier:

  • You can update a single version for multiple artifacts (e.g. Tomcat)
  • You have all the artifacts and their versions at a single place separated from other stuff

See also https://docs.gradle.org/current/userguide/platforms.html

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JacquesLeRoux
Copy link
Contributor

Hi @dtrunk90,

I remember having seen that before, but completly forgot about it.
Could you please update the PR, or create anew. At 1st glance, the conflicts seem a bit hard to resolve

TIA

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dtrunk90
Copy link
Contributor Author

dtrunk90 commented Mar 5, 2024

Hi @JacquesLeRoux,

it took some hours but it's finally done.

@mbrohl
Copy link
Contributor

mbrohl commented Mar 5, 2024

@dtrunk90 Can you elaborate a bit more what advantages this approach brings?
At first glance it seems to make things more complicate?

@JacquesLeRoux
Copy link
Contributor

Hi @dtrunk90, @mbrohl ,

I must say last time I just had a glance, notably on the Gradle Page. After reading a bit more there, with a glance as the resulting code here, I indeed wonder if we need that OOTB.

@dtrunk90, I suggest to start a thread in the dev ML ([email protected]). That's what we do when we hesitate and want to make a community decision. Just few explaining words should be enough.

@JacquesLeRoux
Copy link
Contributor

As a note, here is the Gradle page summary for the catalog feature:

In summary, using a catalog is always a good engineering practice as it centralizes common definitions, allows sharing of dependency versions or plugin versions, but it is an "implementation detail" of the build: it will not be visible to consumers and unused elements of a catalog are just ignored.

Again, not sure we need that, we need to deal with it in depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants