Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16943: Synchronously verify Connect worker startup failure in InternalTopicsIntegrationTest #16451

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

zzzk1
Copy link

@zzzk1 zzzk1 commented Jun 25, 2024

Synchronously verify worker status when created

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@zzzk1
Copy link
Author

zzzk1 commented Jun 26, 2024

@C0urante Could you please take a look? Thank you.

@C0urante
Copy link
Contributor

@zzzk1 Unfortunately, this misses the point of the ticket. If you descend far enough down the call stack for addWorker, you'll see that the DistributedHerder is started, but then begins running on a separate thread. In these tests, we want to verify that that separate thread--which is the "brain" of the worker--has failed with an error. It's not enough to just assert that no workers are running (which I tried to explain on the ticket in the comments section when someone else proposed a similar approach).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants