KAFKA-15623: Remove junit 4 from stream module #16447
Conversation
build.gradle
Outdated
| } | ||
| useJUnitPlatform { | ||
| includeTags "integration" | ||
| includeEngines "junit-jupiter" |
There was a problem hiding this comment.
Could you add it to test task for consistency?
…tPlatform to test task
|
@chia7712, Thanks for your conversations, PTAL |
build.gradle
Outdated
| @@ -482,7 +482,10 @@ subprojects { | |||
|
|
|||
| exclude testsToExclude | |||
|
|
|||
| useJUnitPlatform() | |||
| useJUnitPlatform { | |||
| includeTags "integration" | |||
There was a problem hiding this comment.
this is incorrect. we have three test-related tasks: test, unitTest and integrationTest. test does not need to include/exclude tags. unitTest needs excludeTags "integration" and integrationTest needs includeTags "integration"
There was a problem hiding this comment.
@m1a2st thanks for updated PR.
BTW, could you please remove the duplicate declaration from storage module?
https://github.com/apache/kafka/blob/trunk/build.gradle#L2031
build.gradle
Outdated
| @@ -482,7 +482,9 @@ subprojects { | |||
|
|
|||
| exclude testsToExclude | |||
|
|
|||
| useJUnitPlatform() | |||
| useJUnitPlatform { | |||
| includeEngines "junit-jupiter" | |||
There was a problem hiding this comment.
includeEngines 'junit-jupiter'
| includeTags "integration" | ||
| } | ||
| useJUnitPlatform { | ||
| includeTags "integration" |
There was a problem hiding this comment.
Could you please add specific test engine explicitly?
| excludeTags "integration" | ||
| } | ||
| useJUnitPlatform { | ||
| excludeTags "integration" |
There was a problem hiding this comment.
Could you please add specific test engine explicitly?
remove all junit 4 dependency from stream module
Committer Checklist (excluded from commit message)