Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16751: Implemented release acquired records functionality in SharePartitionManager #16446

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

adixitconfluent
Copy link
Contributor

@adixitconfluent adixitconfluent commented Jun 25, 2024

About

Implemented releaseAcquiredRecords functionality in SharePartitionManager which will act as a bridge between the call from KafkaApis to SharePartition for releasing the acquired records when a share session gets closed.

Testing

The added function has been tested with unit tests.

@adixitconfluent adixitconfluent changed the title Implemented release acquired records in SharePartitionManager KAKFKA-16751: Implemented release acquired records functionality in SharePartitionManager Jun 25, 2024
@adixitconfluent adixitconfluent changed the title KAKFKA-16751: Implemented release acquired records functionality in SharePartitionManager KAFKA-16751: Implemented release acquired records functionality in SharePartitionManager Jun 25, 2024
Copy link
Contributor

@apoorvmittal10 apoorvmittal10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM.

Copy link
Contributor

@omkreddy omkreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adixitconfluent Thanks for the PR. LGTM

@omkreddy omkreddy merged commit 399949e into apache:trunk Jun 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants