-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-17023: add PCollectionsImmutableMap to ConcurrentMapBenchmark #16425
base: trunk
Are you sure you want to change the base?
Conversation
6288d87
to
e36b37f
Compare
e36b37f
to
83b86bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TaiJuWu thanks for patch!
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/ConcurrentMapBenchmark.java
Outdated
Show resolved
Hide resolved
This reverts commit 83b86bc.
ec8dede
to
55f7797
Compare
55f7797
to
8c8a7f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TaiJuWu thanks for this benchmark
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/SingleWriteMultiReadBenchmark.java
Outdated
Show resolved
Hide resolved
8096620
to
54957fb
Compare
@TaiJuWu It seems |
Yes, using |
please take a look at the use case of acl cache. that will be a good start |
*More detailed description of your change,
Add SingleWriteMultiReadBenchmark for ConcurrentHashMap, CopyOnWriteMap, PcollectionsImmutableMap
Running Command:
./jmh-benchmarks/jmh.sh org.apache.kafka.jmh.util.SingleWriteMultiReadBenchmar
Test result:
*Summary of testing strategy (including rationale)
Committer Checklist (excluded from commit message)