feat(azuredevops): support disabled Repos #7657
Conversation
It is now possible to select disabled repositories as a remote scope. However, disabled repositories are not included in tasks related to domain `code` and `code review`, as the Azure DevOps API returns a 4xx status code for the required API calls. A new column called `is_disabled` has been added to the `_tool_azuredevops_go_repos` table to support disabled repositories. For existing entries, the default value for this column is set to `false`.
dosubot
bot
added
size:L
| @@ -39,7 +39,7 @@ var CollectApiPullRequestCommitsMeta = plugin.SubTaskMeta{ | |||
| EntryPoint: CollectApiPullRequestCommits, | |||
| EnabledByDefault: true, | |||
| Description: "Collect PullRequestCommits data from Azure DevOps API.", | |||
| DomainTypes: []string{plugin.DOMAIN_TYPE_CROSS, plugin.DOMAIN_TYPE_CODE_REVIEW}, | |||
There was a problem hiding this comment.
Hello @klesh,
what should be the expected outcome if the user creates a scope configuration with only Cross Domain as the data entity? Should this also include the tasks of domain Code Review and Source Code Management?
There was a problem hiding this comment.
"Code review" should be included alongside "Cross Domain".
"Cross Domain" means it would produce "accounts" records as a byproduct.
"Source Code Management" should not be included because it represents the git repo code base itself.
"Domain Types" are meant to select which subtasks to run but not limit what they could produce. It is simpler this way and most likey more desirable for users.
There was a problem hiding this comment.
Thanks for clarifying. If we classify both the collect-,convert-,extractAccounts tasks and the pullRequests tasks as Cross Domain, we will face issues selecting the correct tasks for disabled ADO repos (and GH repos). Collecting Accounts will work fine, but collecting pull requests will fail. What are your thoughts on this?
Maybe something like this?
entities := scopeConfig.Entities without Cross Domain
tasks := helper.MakePipelinePlanSubtasks(subtaskMetas, entities)
tasks = append(tasks, collect-,convert-,extractAccounts)
There was a problem hiding this comment.
@mr-ks Good question, I think we could use the IgnoreAndContinue technique for certain HTTP status codes as a workaround.
| if azuredevopsRepo.Type != models.RepositoryTypeADO { | ||
| repo, scopeConfig := scope.Scope, scope.ScopeConfig | ||
|
|
||
| if len(scopeConfig.Entities) == 0 { |
There was a problem hiding this comment.
Currently, we are treating this condition as Selected All because it has no point to collect a scope without any entity.
There was a problem hiding this comment.
Thanks for the hint, fixed.
| var err errors.Error | ||
| repo, scopeConfig := scope.Scope, scope.ScopeConfig | ||
|
|
||
| if len(scopeConfig.Entities) == 0 { |
There was a problem hiding this comment.
scopeConfig.Entities are considered as "All Entities".
There was a problem hiding this comment.
Thanks for the hint, fixed.
| } | ||
|
|
||
| func (*disabledRepos) Version() uint64 { | ||
| return 20240806100000 |
There was a problem hiding this comment.
the numbers from the file name and the version are different and both incorrect.
There was a problem hiding this comment.
Fixed and updated the date to today.
| @@ -39,7 +39,7 @@ var CollectApiPullRequestCommitsMeta = plugin.SubTaskMeta{ | |||
| EntryPoint: CollectApiPullRequestCommits, | |||
| EnabledByDefault: true, | |||
| Description: "Collect PullRequestCommits data from Azure DevOps API.", | |||
| DomainTypes: []string{plugin.DOMAIN_TYPE_CROSS, plugin.DOMAIN_TYPE_CODE_REVIEW}, | |||
There was a problem hiding this comment.
"Code review" should be included alongside "Cross Domain".
"Cross Domain" means it would produce "accounts" records as a byproduct.
"Source Code Management" should not be included because it represents the git repo code base itself.
"Domain Types" are meant to select which subtasks to run but not limit what they could produce. It is simpler this way and most likey more desirable for users.
mr-ks
changed the title
Empty entities are not treated as 'Selected All' since collecting a scope without any entity is pointless
Summary
It is now possible to select disabled repositories as a remote scope. However, disabled repositories are not included in tasks related to domain
codeandcode review, as the Azure DevOps API returns a 4xx status code for the required API calls.A new column called
is_disabledhas been added to the_tool_azuredevops_go_repostable to support disabled repositories. For existing entries, the default value for this column is set tofalse.Does this close any open issues?
Closes #7504