Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup cluster for ServiceDiscoveryDemo #2812

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JoeCqupt
Copy link

@JoeCqupt JoeCqupt commented Jun 17, 2024

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #2811

Description

  • Here are some details about my PR, including screenshots of any UI changes:

setup cluster for ServiceDiscoveryDemo

Tests

  • The following tests are written for this issue:

none

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@JoeCqupt JoeCqupt changed the title setup cluster for ServiceDiscoveryDemo [wip] setup cluster for ServiceDiscoveryDemo Jun 17, 2024
@JoeCqupt JoeCqupt changed the title [wip] setup cluster for ServiceDiscoveryDemo setup cluster for ServiceDiscoveryDemo Jun 17, 2024
Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Please make sure admin.close() has been called after end of the block.

@junkaixue
Copy link
Contributor

@JoeCqupt Make sure you have the final message as the merge guidance wiki showed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service-discovery-demo.sh run fail
2 participants