[FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector. #3411
Conversation
… in mysql pipeline connector.
github-actions
bot
added
docs
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** IT tests to cover various newly added tables during capture process in pipeline mode. */ | ||
| public class MysqlPipelineNewlyAddedTableITCase extends MySqlSourceTestBase { |
There was a problem hiding this comment.
Thanks @qg-lin for the PR!
Could you please use Junit5 in the IT test?
There was a problem hiding this comment.
Another PR in progress for Junit5.
|
@qg-lin Thanks for your PR. If you need helps, please be free to notice me. Thanks. |
Thanks for your review, I've resolved it. |
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription( | ||
| "Whether capture the scan the newly added tables or not, by default is false. This option is only useful when we start the job from a savepoint/checkpoint."); |
There was a problem hiding this comment.
Could we drop the capture here?
For example:
Whether to scan the newly added ...
With both capture and scan it seems hard to understand what the flag enables.
...mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java
Outdated
Show resolved
Hide resolved
…line-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java Co-authored-by: Muhammet Orazov <[email protected]>
|
Got it 👍 I missed that there is doc for the flag, the doc version was already understandable. Looks good! |
https://issues.apache.org/jira/browse/FLINK-35143