[FLINK-35490][cdc][JUnit5 Migration] For flink-cdc-connect/flink-cdc-source-connectors module
#3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
mongodb-cdc-connector
mysql-cdc-connector
base
db2-cdc-connector
labels
yuxiqian
reviewed
Jun 21, 2024
| ConnectionPoolId poolId = | ||
| new ConnectionPoolId( | ||
| HOSTNAME, | ||
| PORT, | ||
| USER_NAME, | ||
| DATABASE, | ||
| MockConnectionPoolFactory.class.getName()); | ||
| Assert.assertThrows( | ||
| assertThrowsExactly( |
There was a problem hiding this comment.
Wondering if we can use assertThatThrownBy#isExactlyInstanceOf to replace assertThrowsExactly, and replace JUnit assertions with AssertJ completely?
There was a problem hiding this comment.
Thanks @yuxiqian! Good catch!
Indeed I was planning to migrate totally to assertj where possible, I will update this and check the rest of files 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FLINK-35490
Junit4 to Junit5 migration of
flink-cdc-connect/flink-cdc-source-connectorsmodule. Reference document: Junit5 Migration Guide.