Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3861] Not yet make full use of Polymorphism in Producer and AbstractProducer #3867

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pandaapo
Copy link
Member

@pandaapo pandaapo commented May 4, 2023

Fixes #3861.

Motivation

See "Enhancement Request" in issue

Modifications

See "Describe the solution you'd like" in issue

Documentation

  • Does this pull request introduce a new feature? no

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #3867 (73ec3c0) into master (0ce8d57) will increase coverage by 0.01%.
The diff coverage is 38.46%.

❗ Current head 73ec3c0 differs from pull request most recent head 2c5ca9e. Consider uploading reports for the commit 2c5ca9e to get more accurate results

@@             Coverage Diff              @@
##             master    #3867      +/-   ##
============================================
+ Coverage     14.24%   14.25%   +0.01%     
+ Complexity     1320     1318       -2     
============================================
  Files           579      578       -1     
  Lines         28967    28927      -40     
  Branches       2802     2802              
============================================
- Hits           4125     4123       -2     
+ Misses        24450    24413      -37     
+ Partials        392      391       -1     
Impacted Files Coverage Δ
...eventmesh/storage/kafka/producer/ProducerImpl.java 0.00% <0.00%> (ø)
...ventmesh/storage/pulsar/producer/ProducerImpl.java 0.00% <0.00%> (ø)
...ntmesh/storage/rocketmq/producer/ProducerImpl.java 22.10% <16.66%> (+0.45%) ⬆️
...entmesh/storage/knative/producer/ProducerImpl.java 59.45% <25.00%> (+8.23%) ⬆️
...ge/rocketmq/producer/RocketMQAbstractProducer.java 38.23% <63.63%> (ø)
...rage/knative/producer/KnativeAbstractProducer.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mroccyen
Copy link
Contributor

mroccyen commented May 9, 2023

@pandaapo Please fixes conflict.

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.

Project coverage is 14.25%. Comparing base (0ce8d57) to head (73ec3c0).
Report is 533 commits behind head on master.

Current head 73ec3c0 differs from pull request most recent head 2c5ca9e

Please upload reports for the commit 2c5ca9e to get more accurate results.

Files Patch % Lines
...ntmesh/storage/rocketmq/producer/ProducerImpl.java 16.66% 5 Missing ⚠️
...ge/rocketmq/producer/RocketMQAbstractProducer.java 63.63% 3 Missing and 1 partial ⚠️
...entmesh/storage/knative/producer/ProducerImpl.java 25.00% 3 Missing ⚠️
...eventmesh/storage/kafka/producer/ProducerImpl.java 0.00% 2 Missing ⚠️
...ventmesh/storage/pulsar/producer/ProducerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3867      +/-   ##
============================================
+ Coverage     14.24%   14.25%   +0.01%     
+ Complexity     1320     1318       -2     
============================================
  Files           579      578       -1     
  Lines         28967    28927      -40     
  Branches       2802     2802              
============================================
- Hits           4125     4123       -2     
+ Misses        24450    24413      -37     
+ Partials        392      391       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pil0tXia Pil0tXia changed the title [ISSUE #3861]Not yet make full use of Polymorphism in Producer and AbstractProducer. [ISSUE #3861] Not yet make full use of Polymorphism in Producer and AbstractProducer Apr 23, 2024
@github-actions github-actions bot removed the Stale label Apr 23, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Not yet make full use of Polymorphism in Producer and AbstractProducer.
5 participants