fix: clipping in custom series off by pixel#19993

[fandi-1205]

Brief Information

This pull request is in the type of:

• bug fixing
• new feature
• others

What does this PR do?

#19993 Clipping in custom series off by 1 pixel

Fixed issues

Details

Before: What was the problem?

There is a boundary overflow issue when creating a clipping path in the custom series.

After: How does it behave after the fixing?

The overflow occurs because the clipping path is widened to fully display the first and last ends of the line chart. In the source code, the logic is to first obtain the width of the polyline, and adjust the clipping path based on this width. After consulting the documentation, I found that under custom If you do not set the lineStyle attribute, you must ensure that the chart without the lineStyle attribute is trimmed strictly according to the grid. Then you only need to set the chart without the lineStyle attribute not to expand.

This change will have an impact on charts that do not have the lineStyle.width attribute but use a clipping path, but the impact is reasonable and acceptable, such as the following case

Document Info

One of the following should be checked.

• This PR doesn't relate to document changes
• The document should be updated later
• The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

• This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

• Please squash the commits into a single one when merging.

Other information

[echarts-bot]

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

[Ovilia]

Thanks for your contribution!

It seems that the expected clipped area of the custom series on grid is not correct yet.

With

axisLine: {
  lineStyle: {
    width: 50,
    color: 'rgba(255, 0, 0, 0.2)'
  }
}

we can see that current clipped area excludes half axisLine width, which is not expected because this makes api.coord(0, 0) not at the position of the origin of the axes.

So axisLine width should probably not considered in this case.

[github-actions]

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20043@58cb454

[Ovilia]

Tested with visual testing and some cases failed with bar series and are considered to be as expected.

[echarts-bot]

Congratulations! Your PR has been merged. Thanks for your contribution! 👍