Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix and align section names #232

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

duesee
Copy link

@duesee duesee commented Jun 4, 2024

Overall Review of Changes:
Minor improvements to casing, and a fix for a section title.

Issue Fixes:
None, (should I open first?).

Enhancements:
Playbook is now better aligned to the document.

How has this been tested?:
I didn't test because I believe no tests are required.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

uk-bolly
uk-bolly previously approved these changes Jun 10, 2024
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tidy up thank you

@uk-bolly uk-bolly self-requested a review June 10, 2024 09:40
@uk-bolly uk-bolly dismissed their stale review June 10, 2024 09:41

Missing GPG signature

@uk-bolly
Copy link
Member

hi @duesee

Thank you so much for taking the time for this PR and nice nice spots. Unfortunately the commits are not GPG signed which are required in order to merge this PR. If you are able to resolve this (it will show verified next to each commit in the list).

Many thanks

uk-bolly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants