add sticky toc #2445
Open
add sticky toc #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for adding this feature. the only issue I noticed is that transparent background of the sticky toc doesn't look good when the toc bloc starts overlapping with other objects on the page. also, this won't work on mobile well. could you think of a way to fix these issues?
|
alshedivat
requested changes
May 27, 2024
|
@alshedivat great point - thanks for the feedback. I'll take a look. |
|
How did you envision this collapsible toc in this case? Where and how it would appear on mobile? I tend to think that just hiding the toc would be a good use, since the mobile screen is too small to fit both the toc and the contents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sticky toc to the Distill template as mentioned in #1961
Changes: