Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Message): The styles of the outer Message component will affect the inner component when nested, close #4851 #4856

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wangw11056
Copy link
Collaborator

@wangw11056 wangw11056 commented Jun 4, 2024

close #4851

@@ -60,4 +60,32 @@ describe('Message issues', () => {
assert(iconPos.height === contentPos.height);
assert(iconPos.y === contentPos.y);
});

// Fix: https://github.com/alibaba-fusion/next/issues/4851
it('should be rendered correctly styles when Message components are nested within each other', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这个英文不太通顺,可以用 copilot 或者 chatgpt 翻译一下修改一下,同时也更新一下 pr 的 title。

@wangw11056 wangw11056 changed the title fix(Message): Style override problem when Message components are nest… fix(Message): should style not cover when nested Jun 25, 2024
@wangw11056 wangw11056 changed the title fix(Message): should style not cover when nested fix(Message): should style not cover when nested, close #4851 Jun 25, 2024
@wangw11056 wangw11056 changed the title fix(Message): should style not cover when nested, close #4851 fix(Message): The styles of the outer Message component will affect the inner component when nested, close #4851 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Message]Dialog 套Message,Message的Icon 会被覆盖掉
2 participants