refactor(Upload): convert to TypeScript, impove docs and tests, close #4622 #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
FairyYang
changed the title
eternalsky
requested changes
May 29, 2024
FairyYang
force-pushed
the
form-update
branch
2 times, most recently
from
6e7820e
to
4abb28c
Compare
eternalsky
reviewed
Jun 20, 2024
eternalsky
requested changes
Jun 20, 2024
|
重新提交了一版 |
|
重新打开PR |
eternalsky
requested changes
Jun 26, 2024
| saveUploaderRef = ref => { | ||
| uploaderRef: ReturnType<InstanceType<typeof Upload>['getInstance']>; | ||
|
|
||
| saveUploaderRef = (ref: InstanceType<typeof Upload>) => { |
|
|
||
| it('should support change Data/Action/Headers in BeforeUpload', () => { | ||
| class App extends React.Component { | ||
| constructor(props: object) { |
There was a problem hiding this comment.
object 在 ts 里并不是代表 js 里的 Object，这里其实可以把 state 从 constructor 里拿出去，然后 constructor 删掉，类似 demo
| assert(fileToObject(file).uid === file.uid); | ||
| }); | ||
|
|
||
| it('getFileItem', () => { | ||
| const file = { uid: 1, 1: 1 }; | ||
| const files = [file, { uid: 2, 2: 2 }]; | ||
| const file = { uid: 1, 1: 1 } as unknown as OriginalFile; |
There was a problem hiding this comment.
这里还是有很多 as unknown，理论上 as known 应该都不存在
components/upload/card.tsx
Outdated
| @@ -161,23 +135,24 @@ class Card extends Base { | |||
| showDownload, | |||
| } = this.props; | |||
|
|
|||
| // @ts-expect-error limit可能为undefined | |||
| @@ -194,7 +169,7 @@ class Card extends Base { | |||
| listType="card" | |||
| closable | |||
| locale={locale} | |||
| value={this.state.value} | |||
| value={this.state.value as UploadFile[]} | |||
There was a problem hiding this comment.
state.value 本身不就是 UploadFile[] 吗，这里为什么还需要 as
|
|
||
| componentDidMount() { | ||
| const { props } = this; | ||
| const options = this.getUploadOptions(props); | ||
| this.uploader = new Uploader(options); | ||
| this.uploader = new Uploader(options as unknown as UploadOptions); |
| @@ -89,7 +56,7 @@ export default class Html5Uploader extends Component { | |||
| for (let i = 0; i < keys.length; i++) { | |||
| const key = keys[i]; | |||
| if (options[key] !== preOptions[key]) { | |||
| this.uploader.setOptions(options); | |||
| this.uploader.setOptions(options as unknown as UploadOptions); | |||
| } else { | ||
| formData.append(option.filename, option.file); | ||
| formData.append(option.filename!, option.file as unknown as Blob); |
| xhr.onerror = function error(e) { | ||
| option.onError(e); | ||
| xhr.onerror = function error(e: ProgressEvent<EventTarget>) { | ||
| option.onError!(e as unknown as UploadError); |
components/upload/util.ts
Outdated
| const reader = new FileReader(); | ||
| reader.onloadend = () => callback(reader.result); | ||
| reader.readAsDataURL(file); | ||
| reader.readAsDataURL(file as unknown as Blob); |
|
提交了一个commit，修复了上面的问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4622