Bug/fix matrix apply to vector #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this cascades into a number of other functions =/ |
|
Any updates here? |
|
Unfortunately the PR breaks more things.
…On Wed, Sep 2, 2020 at 3:27 pm, Gavan Wilhite ***@***.***> wrote:
Any updates here?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJOQ5ABZZW5HZS2HNSKK63SD3BGXANCNFSM4JSYGVWA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
This pull request fixes #97 . The order of multiplication of the matrix and the vector in
apply_to_vectorwas inverted. I added tests with 90 degrees rotations because the tests with rotation of 180 degrees do not highlight this type of error.Types of changes