Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] React Aria Button on Modals #2918

Open
wants to merge 2 commits into
base: react-aria-button-5
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

@github-actions github-actions bot changed the title React Aria Button on Modals [WIP] React Aria Button on Modals Jun 21, 2024
@github-actions github-actions bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jun 21, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.98 MB → 4.99 MB (+4.7 kB) +0.09%
Changeset
File Δ Size
node_modules/react-aria-components/dist/Form.mjs 🆕 +1.88 kB 0 B → 1.88 kB
node_modules/@react-stately/form/dist/useFormValidationState.mjs 🆕 +83 B 0 B → 83 B
src/components/modals/SingleInputModal.tsx 📈 +155 B (+8.28%) 1.83 kB → 1.98 kB
src/components/modals/ConfirmTransactionDelete.tsx 📈 +75 B (+5.52%) 1.33 kB → 1.4 kB
src/components/modals/ConfirmUnlinkAccount.tsx 📈 +75 B (+4.94%) 1.48 kB → 1.56 kB
src/components/modals/SwitchBudgetTypeModal.tsx 📈 +76 B (+3.86%) 1.92 kB → 2 kB
src/components/modals/FixEncryptionKeyModal.tsx 📈 +156 B (+2.92%) 5.21 kB → 5.37 kB
src/components/modals/ConfirmTransactionEdit.tsx 📈 +80 B (+2.84%) 2.75 kB → 2.83 kB
src/components/modals/CreateAccountModal.tsx 📈 +378 B (+2.82%) 13.1 kB → 13.47 kB
src/components/modals/LoadBackup.jsx 📈 +108 B (+2.29%) 4.6 kB → 4.71 kB
src/components/modals/NotesModal.tsx 📈 +41 B (+2.18%) 1.84 kB → 1.88 kB
src/components/modals/SelectLinkedAccounts.jsx 📈 +132 B (+1.88%) 6.84 kB → 6.97 kB
src/components/modals/HoldBufferModal.tsx 📈 +33 B (+1.85%) 1.74 kB → 1.78 kB
src/components/modals/EditField.jsx 📈 +131 B (+1.79%) 7.13 kB → 7.26 kB
src/components/modals/MergeUnusedPayees.jsx 📈 +100 B (+1.56%) 6.26 kB → 6.36 kB
src/components/modals/SimpleFinInitialise.tsx 📈 +37 B (+1.52%) 2.38 kB → 2.41 kB
src/components/modals/CoverModal.tsx 📈 +37 B (+1.51%) 2.39 kB → 2.43 kB
src/components/modals/CategoryGroupMenuModal.tsx 📈 +83 B (+1.43%) 5.65 kB → 5.73 kB
src/components/modals/GoCardlessExternalMsg.tsx 📈 +105 B (+1.22%) 8.44 kB → 8.54 kB
src/components/modals/TransferModal.tsx 📈 +39 B (+1.19%) 3.21 kB → 3.25 kB
src/components/modals/EditRule.jsx 📈 +416 B (+1.18%) 34.48 kB → 34.89 kB
src/components/modals/GoCardlessInitialise.tsx 📈 +37 B (+1.11%) 3.25 kB → 3.28 kB
src/components/modals/CloseAccountModal.tsx 📈 +90 B (+1.06%) 8.3 kB → 8.39 kB
src/components/modals/ReportBudgetMonthMenuModal.tsx 📈 +51 B (+1.00%) 4.96 kB → 5.01 kB
src/components/modals/RolloverBudgetMonthMenuModal.tsx 📈 +51 B (+0.98%) 5.09 kB → 5.14 kB
src/components/modals/ConfirmCategoryDelete.tsx 📈 +39 B (+0.94%) 4.07 kB → 4.11 kB
src/components/modals/AccountMenuModal.tsx 📈 +39 B (+0.80%) 4.76 kB → 4.8 kB
src/components/modals/CategoryMenuModal.tsx 📈 +39 B (+0.78%) 4.9 kB → 4.94 kB
src/components/modals/CreateEncryptionKeyModal.tsx 📈 +61 B (+0.77%) 7.69 kB → 7.75 kB
src/components/modals/ImportTransactions.jsx 📈 +124 B (+0.31%) 38.47 kB → 38.59 kB
src/components/modals/CreateLocalAccountModal.tsx 📈 +19 B (+0.31%) 5.98 kB → 6 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.25 MB → 3.25 MB (+4.7 kB) +0.14%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 75.73 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.22 kB 0%
static/js/wide.js 267.23 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP Still work-in-progress, please don't review and don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant