React Aria Button as base of Button component #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
🚧 WIP
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
joel-jeremy
force-pushed
the
react-aria-button
branch
from
f36a391
to
3660d22
Compare
joel-jeremy
changed the title
github-actions
bot
added
🔍 Ready for Review
joel-jeremy
force-pushed
the
react-aria-button
branch
from
f88e4c6
to
37ba9cf
Compare
|
Might it be easier to keep the existing prop interface for the Your approach is totally fine too and I'm happy to proceed with it though. Just looking out for your sanity since it's A LOT of buttons that will need to be updated. |
|
I think this approach is the way to go because right now we won't be able to do a bulk port to the react aria button because there seems to be a compatibility issue with the current modal we have. There is an issue on some places of the code where when clicking a button that opens a modal, the modal gets closed immediately (my assumption is that the modal we have right now detects the onMouseUp event and triggers the "shouldCloseOnInteractOutside" logic). But outside that the new aria buttons works as expected. I will also be working on porting Modal to use react aria Modal components to address that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be the first part of a multi-PR effort to migrate all the buttons in the code to use react-aria-components' Button component under the hood. The plan is to do one PR per page to make it easier to review the changes.
This first one migrates the buttons on the schedules page.