Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suport false value when creating google-contact #4921

Closed
wants to merge 1 commit into from

Conversation

ikus060
Copy link
Contributor

@ikus060 ikus060 commented Jun 13, 2024

What does this PR do?

Using dynamic value for phoneNumber, companyName and email when creating Google Contact, if the dynamic value has a boolean value of false, it get converted into string "false" and the value created in Google Contact is "false".

I'm not sure this would be the expected result for users. I'm not sure of the policies regarding data conversion between types in ActivePieces either. So you are free to recommend me alternative implementation. I will do the same for the update-contact action I'm working on.

e.g.: in Google Contacts
image

e.g.: In Activepieces
image

Copy link

nx-cloud bot commented Jun 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4f7e866. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@ikus060
Copy link
Contributor Author

ikus060 commented Jun 14, 2024

Working on new implementation.

@abuaboud
Copy link
Contributor

I feel this is intended @ikus060 why not pass for example an empty / null string then It would skip phone number / email.

Not sure if i understand you correctly.

@abuaboud abuaboud added the blocked: waiting-response waiting a response from the user label Jun 14, 2024
@ikus060
Copy link
Contributor Author

ikus060 commented Jun 15, 2024

@abuaboud I come from Python world where False, None and Empty string are all equals. That might just be it.

@abuaboud
Copy link
Contributor

Hi @ikus060

I think this will has side effect, I think it's better to try empty string or send undefined / null

I am closing this PR, please let me know if the other way doesn't work

@abuaboud abuaboud closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: waiting-response waiting a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants