Request microphone permission when recording video #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YPVideoCaptureHelper supports capturing audio, but YPImagePicker does not request microphone permission. As a result, videos silently fail to include audio unless the client app preemptively requests audio permission prior to opening YPImagePicker. In contrast, YPImagePicker does request photo library permission (in YPLibraryVC) and camera permission (in YPCameraVC and YPVideoCaptureVC). With this change, YPVideoCaptureVC also requests microphone permission, standardizing YPImagePicker's behavior across the three permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YPVideoCaptureHelpersupports capturing audio, but YPImagePicker does not request microphone permission. As a result, videos silently fail to include audio unless the client app preemptively requests audio permission prior to opening YPImagePicker.In contrast, YPImagePicker does request photo library permission (in
YPLibraryVC) and camera permission (inYPCameraVCandYPVideoCaptureVC). With this change,YPVideoCaptureVCalso requests microphone permission, standardizing YPImagePicker's behavior across the three permissions.