-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TabbarItem): use single Tappable #5914
base: master
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7f8036d:
|
e2e tests |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5914 +/- ##
==========================================
+ Coverage 79.13% 79.18% +0.05%
==========================================
Files 312 315 +3
Lines 9957 10021 +64
Branches 3332 3349 +17
==========================================
+ Hits 7879 7935 +56
- Misses 2078 2086 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit 7f8036d |
1bf6309
to
99d46f8
Compare
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
w/ new pure-ish css Ripple
and update markup
99d46f8
to
fb4a90d
Compare
Чеклист
Unit-тестыe2e-тестыОписание
Зашла в TabbarItem в процессе приведения в порядок аутлайнов внутри FocusVisible, поняла, что нужен небольшой рефакторинг, чтобы все работало как надо.
Изменения
TabbarItem