Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tweak settings designs (#2537) #2561

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

mike-kiss
Copy link
Collaborator

@mike-kiss mike-kiss commented Jun 3, 2024

This PR:

  • Switches the channel settings menu over to using a Drawer component
  • Adds a README.md to establish UI development practices on the desktop app

Pull Request Checklist

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@mike-kiss mike-kiss changed the title DRAFT: Fix/tweak settings designs (#2537) Fix/tweak settings designs (#2537) Jun 5, 2024
@mike-kiss mike-kiss requested review from leblowl, siepra and EmiM and removed request for siepra June 5, 2024 17:29
@mike-kiss
Copy link
Collaborator Author

mike-kiss commented Jun 5, 2024

Light Mode:
image
image
image

Dark mode:
image
image
image

@holmesworcester holmesworcester removed the request for review from EmiM June 5, 2024 20:59
@holmesworcester
Copy link
Contributor

@jgaylor do you have any feedback on these screenshots? (this is mike's adaptation of the new mobile-style settings designs for desktop.)

@jgaylor
Copy link
Collaborator

jgaylor commented Jun 7, 2024

Thanks for sharing this. Here are some quick thoughts:

Dark/light mode: Overall, it looks good except for the radio buttons and the visibility icon. For icons, we should probably use grayscale. For radios in dark mode, the colors should be reversed, but that would be temporary anyway based on my comments later...

Panels: It's difficult to tell if they all have the same width since the screenshots are at various zoom levels, but they should if not.

Additionally, we're mixing existing content layout with the new drawer, so there's no clear guide for how that should look. And design should layout this view in the new system. For example, the Notifications drawer needs a design that matches our new convention (action row with a checkmark).

Holmes mentioned this will be on a branch soon, which will make it easier for me to review in more detail.

@ikoenigsknecht
Copy link
Collaborator

Code looks good but we should fix the desktop tests. That should just require updating snapshots.

Copy link
Collaborator

@ikoenigsknecht ikoenigsknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We can alter the length of the hidden invite link to fit the drawer now or later, doesn't matter to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants