This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Enhancements and Modernization of Test Classes #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've submitted a pull request with some improvements to enhance the code quality of project. Here’s a quick summary:
JUnit5 Tests to Default Visibility: Removed "public" keyword from test classes and methods for cleaner, more idiomatic JUnit5 code. Assertion Argument Order: Corrected the order of arguments in assertions for consistency. Removed Unused Imports: Cleaned up the codebase by removing unnecessary imports. Java 11 String Handling: Updated file handling with Files.readString() and Files.writeString() for better efficiency and readability.
These changes are fully tested and aim to contribute to the project’s maintainability. Looking forward to any feedback and hoping for a smooth merge.
Thanks for your consideration!
Best regards,