Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing iframes - fixes v5.5 issues #476

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vallme2003
Copy link

Changes :

(1) Removed existing iframes: Before creating a new iframe, the script checks for and removes any existing iframes.

(2) Ensured single video element: The script removes existing video elements before creating new ones to prevent overlapping audio.

Changes :

(1) Removed existing iframes: Before creating a new iframe, the script checks for and removes any existing iframes.

(2) Ensured single video element: The script removes existing video elements before creating new ones to prevent overlapping audio.
@vallme2003 vallme2003 changed the title Remove existing iframes Remove existing iframes - fixes v5.5 issues Jun 5, 2024
Copy link

@vermaysha vermaysha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes it works, sometimes it doesn't

@vallme2003
Copy link
Author

Sometimes it works, sometimes it doesn't

Thanks for checking. I am able to see it working with Chrome v125 on mac and with existing adblockers disabled. If there is a certain OS + browser combination where you see the intermittent behavior, plz add it here to check. Thanks!

@jmpfbmx
Copy link

jmpfbmx commented Jun 5, 2024

Sometimes it works, sometimes it doesn't

Thanks for checking. I am able to see it working with Chrome v125 on mac and with existing adblockers disabled. If there is a certain OS + browser combination where you see the intermittent behavior, plz add it here to check. Thanks!

I have been testing it with Firefox 126.0.1 on Windows and sometimes failed.

@mviscovo2004
Copy link

this solution only work on the first video u watch after reloading the website.
i have tested it on opera gx 109.0.5097.108 on windows

Copy link

@Ameer-Jamal Ameer-Jamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this

@CatPieLeaf
Copy link
Contributor

CatPieLeaf commented Jun 6, 2024

Sometimes it works, sometimes it doesn't

Thanks for checking. I am able to see it working with Chrome v125 on mac and with existing adblockers disabled. If there is a certain OS + browser combination where you see the intermittent behavior, plz add it here to check. Thanks!

I have been testing it with Firefox 126.0.1 on Windows and sometimes failed.

Same here in Vivaldi 6.7.3329.39. but it always fail and i have to reload the page until no ad or duplicated audio appears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants