-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove existing iframes - fixes v5.5 issues #476
base: main
Are you sure you want to change the base?
Conversation
Changes : (1) Removed existing iframes: Before creating a new iframe, the script checks for and removes any existing iframes. (2) Ensured single video element: The script removes existing video elements before creating new ones to prevent overlapping audio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes it works, sometimes it doesn't
Thanks for checking. I am able to see it working with Chrome v125 on mac and with existing adblockers disabled. If there is a certain OS + browser combination where you see the intermittent behavior, plz add it here to check. Thanks! |
I have been testing it with Firefox 126.0.1 on Windows and sometimes failed. |
this solution only work on the first video u watch after reloading the website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of this
Same here in Vivaldi 6.7.3329.39. but it always fail and i have to reload the page until no ad or duplicated audio appears |
Changes :
(1) Removed existing iframes: Before creating a new iframe, the script checks for and removes any existing iframes.
(2) Ensured single video element: The script removes existing video elements before creating new ones to prevent overlapping audio.