Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init out struct parameters to prevent NullReferenceReference #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UlyssesWu
Copy link

@UlyssesWu UlyssesWu commented Oct 31, 2023

Reason:

internal static unsafe object ToObject(Value* evaluationStackBase, Value* evaluationStackPointer,
object[] managedStack, Type type, VirtualMachine virtualMachine, bool valueTypeClone = true)
{
//未初始化的local引用可能作为out参数反射调用
//TODO: 验证值类型out参数,对应参数位置是否可以是null?

Known issue, but never fixed😅

Test case:

        public struct TestStruct
        {
            public int a;
            public string b;
        }

        [Patch]
        public void TestOutStruct(out TestStruct ts)
        {
            ts.a = 114514;
            ts.b = "buggy IFix";
        }

        public void Awake() // must not be [Patch]ed
        {
            TestStruct ts;
            TestOutStruct(out ts);
        }

@tencent-adm
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants