-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable completely offline st2-rule-tester #6208
Open
jk464
wants to merge
1
commit into
StackStorm:master
Choose a base branch
from
jk464:feature/offline-rule-tester
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a03856f
to
cc2ca22
Compare
I tested to make sure that w/o
|
cc2ca22
to
977baaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable offline testing of StackStorm rules (i.e. in a CI pipeline) this PR allows
st2-rule-tester
to run w/o a MongoDB connection (which was the only external requirement the script required)st2-rule-tester
only requires a connection to Mongo if you use therule-ref
and/ortrigger-instance-id
flags - as they reference entries in the MongoDB. If you only want to providerule
andtrigger-instance
yaml
files (for example in CI testing pipeline ofrules
w/in apack
) then the Mongo connection is never required.This PR adds an
--offline
flag, which if provided, skips the setting up of the mongo connection - otherwise (and by default) the connection is still setup.There's also a check that if the
--offline
flag is provide that neitherrule-ref
and/ortrigger-instance-id
flags are provided - and if so exits with an error informing the user they can't be used in conjunction with the--offline
flag.This enables the following usecase https://stackstorm-community.slack.com/archives/C066APT88/p1716561254326499