feat: date time picker improvements #5297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
force-pushed
the
global-time-range-improvements
branch
from
874afe2
to
092cf69
Compare
a6kme
reviewed
Jun 21, 2024
vikrantgupta25
force-pushed
the
global-time-range-improvements
branch
from
138a4ae
to
907e044
Compare
srikanthccv
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Two minor issue https://www.loom.com/share/6d79a063386748e180938c7d4320424f
|
@srikanthccv addressed the comments. |
|
Functionally LGTM. This is a good change but not an urgent one so please add tests. |
yes will merge this post adding the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
1 week/s , minute/s , hour/s, day/sin the date time picker inputRelated Issues / PR's
fixes #4321
fixes #4322
Screenshots
NA
Affected Areas and Manually Tested Areas