PixelPaint: Fixed some Color Masking issues #24580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
Torstennator
force-pushed
the
pixelpaint_fixes
branch
from
09860eb
to
b8a2553
Compare
|
https://github.com/SerenityOS/serenity/blob/master/CONTRIBUTING.md#code-submission-policy
And since it's two independent things, maybe it should be two commits? Otherwise looks good, thanks for the PR! |
nico
added
⏳ pr-waiting-for-author
This change solves a crash where it was possible that the "Color Masking" could try to access pixel coordinates that where beyond the boundaries of the image.
Torstennator
force-pushed
the
pixelpaint_fixes
branch
from
b8a2553
to
d64725d
Compare
github-actions
bot
added
👀 pr-needs-review
nico
reviewed
Jun 26, 2024
nico
added
⏳ pr-waiting-for-author
This change solves a problem where the color selection via mouse click on the color wheel was computing a wrong hue angle.
Torstennator
force-pushed
the
pixelpaint_fixes
branch
from
d64725d
to
d402e4e
Compare
github-actions
bot
added
👀 pr-needs-review
|
Thanks! |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where pixelpaint was crashing when trying to refine an editing mask with the "Color Masking" feature because we where accessing pixel coordinates that where beyond the boundaries. Furthermore a change was made to make the color masking hue selection work again with mouse clicks directly on the color wheel.