Calculator: Add c constant #24576
Calculator: Add c constant #24576
Conversation
I have added the "c" constant to the calculator, this is the speed of light in a vacuum, 299,792,458 metres/second. Figured it would be an interesting thing to have.
github-actions
bot
added
the
👀 pr-needs-review
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
|
the WIP icon |
There was a problem hiding this comment.
Welcome to the project!
There are several issues that prevent the commit to be merged as is:
- There are issues with your commit message, that's why the CI is failing. You can look at the details to see what's wrong.
- You didn't add the image to the repo, so the code you submitted will make the Calculator crash on startup. That being said, I would rather not have an icon that having a "quick and dirty" one. The icon could be added later on.
To apply any of these, please fix up the modification in the current commit rather than adding a new one / creating a new PR. Don't hesitate to ask on Discord for help.
| @@ -79,7 +79,9 @@ ErrorOr<int> serenity_main(Main::Arguments arguments) | |||
| constants_menu->add_action(GUI::Action::create("&Phi", TRY(Gfx::Bitmap::load_from_file("/res/icons/calculator/phi.png"sv)), [&](auto&) { | |||
| widget->set_typed_entry(Crypto::BigFraction { Crypto::SignedBigInteger(16180339887), power }); | |||
| })); | |||
|
|
|||
There was a problem hiding this comment.
I liked this empty line :/
| @@ -79,7 +79,9 @@ ErrorOr<int> serenity_main(Main::Arguments arguments) | |||
| constants_menu->add_action(GUI::Action::create("&Phi", TRY(Gfx::Bitmap::load_from_file("/res/icons/calculator/phi.png"sv)), [&](auto&) { | |||
| widget->set_typed_entry(Crypto::BigFraction { Crypto::SignedBigInteger(16180339887), power }); | |||
| })); | |||
|
|
|||
| constants_menu->add_action(GUI::Action::create("&C", TRY(Gfx::Bitmap::load_from_file("/res/icons/calculator/c.png"sv)), [&](auto&) { | |||
| widget->set_typed_entry(Crypto::BigFraction { Crypto::SignedBigInteger(2997924580000000000), power }); | |||
There was a problem hiding this comment.
You're doing extra work here, instead of manually multiplying by 10**10 and dividing by power, let's just not divide by anything (BigFraction has a constructor that default the denominator to zero):
| widget->set_typed_entry(Crypto::BigFraction { Crypto::SignedBigInteger(2997924580000000000), power }); | |
| widget->set_typed_entry(Crypto::BigFraction { "299792458"_sbigint }); |
Thank you! I will be sure to look and make these changes when I am back at my computer, in a couple of hours. |
I have added the "c" constant to the calculator
This is the speed of light in a vacuum, 299,792,458 metres/second.
I Figured it would be an interesting thing to have added.
I also have created a quick and dirty c icon, that should be replaced.
It should be considered a placeholder for now.