Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Description
The main change is changing the return type hint for
def get_downloadable_files(self)
fromdict
toList[str]
, which is actually what is returned.Also some cosmetic improvements have been added.
Motivation and Context
I caught some error from my static type checker () and saw that
![image](https://private-user-images.githubusercontent.com/61578484/341617547-9e053334-a976-40b3-b066-46ecab7442ec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MzQ2MTEsIm5iZiI6MTcxOTYzNDMxMSwicGF0aCI6Ii82MTU3ODQ4NC8zNDE2MTc1NDctOWUwNTMzMzQtYTk3Ni00MGIzLWIwNjYtNDZlY2FiNzQ0MmVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDA0MTE1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZmOTRmNDc3NmVhOTllZDlhZjdlNTQ0MGI5YmRlOTVlNzNhYTFlN2YwYzczOTg0YmY0Mjk4YjA1OWI4N2Y4NDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.MUnDv-aDyUXkNnwNsNJ2GvvuaUDQFLPbrUvuy6-5q6M)
get_downloadable_files
has the wrong type annotation and decided to fix it =)Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
get_downloadable_files
fromdict
toList[str]
to accurately reflect the returned value.__exit__
,get_cookie
, and others to useOptional
andType
fromtyping
.Changes walkthrough 📝
webdriver.py
Fix type hints and improve code formatting in `webdriver.py`
py/selenium/webdriver/remote/webdriver.py
get_downloadable_files
fromdict
toList[str]
.