-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DelegatedConda with Delegated #5963
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5963 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 90 90
Lines 22984 22984
Branches 5031 5031
=======================================
Hits 20634 20634
Misses 1619 1619
Partials 731 731 ☔ View full report in Codecov by Sentry. |
⏱️ Performance Benchmark Report: f5bf5b7Performance shifts
Full benchmark results
Generated by GHA run |
⏱️ Performance Benchmark Report: 7c75a23Performance shifts
Full benchmark results
Generated by GHA run |
Hoping to have this in by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks @trexfeathers!
Thanks @ESadek-MO! |
🚀 Pull Request
Description
This new approach to managing our benchmark environments provides:
asv.plugins.conda.Conda
, which merited several adaptations to get that particular setup to work. Now we just subclass the coreasv.environments.Environment
.asv.conf.json
structure to avoid 'coupling' between separate config items.asv.conf.json
makes it possible to benchmark commits that need different environment setup commands (e.g. different Nox calls for different Python versions).Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: