ENHANCE: Avoid UBSAN errors #1289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index -1 out of bounds for type 'definition_ref[7]'
index -1 out of bounds for type 'definition_ref[7]'
addition of unsigned offset to 0x7f6d6eb33000 overflowed to 0x7f6d6eb32fff
applying non-zero offset 64 to null pointer
applying non-zero offset 8864 to null pointer (from incrementing NULL with ++)
index -1 out of bounds for type 'definition_ref[7]'
member access within null pointer of type 'struct clause'
applying non-zero offset 64 to null pointer
member access within null pointer of type 'var_table'
member access within null pointer of type 'struct bit_vector'
|
The above mentioned issue is here, #1290 |
If stack->top is NULL, switch to else branch
If stack->top is NULL, switch to ":" branch
|
I think the remaining problems have been solved with the last two commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here: https://www.stats.ox.ac.uk/pub/bdr/memtests/clang-UBSAN/rswipl/rswipl.log
The individual errors are mentioned in the individual commits. Four error messages are still left, these require inspection, I'll open an issue.