Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression(E2EEncryption): Service Worker not installing on first load #32674

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

rodrigok
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: cc374c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rodrigok rodrigok added this to the 6.10 milestone Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.72%. Comparing base (326bd01) to head (cc374c9).
Report is 2 commits behind head on release-6.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.0   #32674      +/-   ##
==================================================
- Coverage           56.73%   56.72%   -0.01%     
==================================================
  Files                2496     2493       -3     
  Lines               55360    55326      -34     
  Branches            11455    11452       -3     
==================================================
- Hits                31406    31385      -21     
+ Misses              21282    21242      -40     
- Partials             2672     2699      +27     
Flag Coverage Δ
e2e 56.47% <31.57%> (+<0.01%) ⬆️
unit 71.84% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title fix(E2EEncryption): Service Worker not installing on first load regression(E2EEncryption): Service Worker not installing on first load Jun 25, 2024
@rodrigok rodrigok marked this pull request as ready for review June 27, 2024 20:19
@rodrigok rodrigok requested a review from a team as a code owner June 27, 2024 20:19
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 28, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2024
@kodiakhq kodiakhq bot merged commit 4657d2b into release-6.10.0 Jun 28, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/sw-first-install branch June 28, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants