test: Fixing a weird problem happening when running the autojoin tests #32614
Conversation
for some reason they would sometimes pass, and sometimes fail with weird error messages There were some weird after/afterEach in this test which I decided to remove to check what was happening and it looks like that did the trick
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32614 +/- ##
===========================================
- Coverage 56.39% 55.72% -0.68%
===========================================
Files 2479 2416 -63
Lines 54580 53470 -1110
Branches 11268 11002 -266
===========================================
- Hits 30780 29794 -986
+ Misses 21125 21052 -73
+ Partials 2675 2624 -51
Flags with carried forward coverage won't be shown. Click here to find out more. |
Gustrb
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
| afterEach(() => | ||
| Promise.all([deleteTeam(credentials, testTeam.name), deleteRoom({ roomId: createdRoom.body.channel._id, type: 'c' })]), | ||
| ); | ||
|
|
There was a problem hiding this comment.
this should continue in "after" if the test fails it will not remove the rooms
ggazzo
removed
the
stat: QA assured
dionisio-bot
bot
removed
the
stat: ready to merge
|
The root cause was that sometimes users were being created with the same name, since the name is created through a Random Number Generator, #32634 is the correct solutions. |
Proposed changes (including videos or screenshots)
For some reason they would sometimes pass, and sometimes fail with weird error messages.
There were some weird after/afterEach in this test which I decided to remove to check what was happening and it looks like that did the trick :)
Issue(s)
Steps to test or reproduce
Further comments