-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Inconsistent Markdown Formatting in Custom Status Field #32574
base: develop
Are you sure you want to change the base?
fix: Inconsistent Markdown Formatting in Custom Status Field #32574
Conversation
🦋 Changeset detectedLatest commit: 04653c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32574 +/- ##
========================================
Coverage 56.33% 56.34%
========================================
Files 2433 2437 +4
Lines 53707 53781 +74
Branches 11062 11085 +23
========================================
+ Hits 30258 30303 +45
- Misses 20801 20860 +59
+ Partials 2648 2618 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hey, thanks for your contribution, I was testing it and it fixes the issue with bold and one italic but not the other one, these text test test test |
Screen.Recording.-.Jun.11.2024.1.mp4@csuadev I have test the updated code with the specified markdown inputs to ensure all cases are handled correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests to ensure the behavior? cc @csuadev
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
https://rocketchat.atlassian.net/browse/SUP-537
Proposed changes (including videos or screenshots)
Screen.Recording.-.Jun.8.2024.mp4
Issue(s)
#32544
#32081
Steps to test or reproduce
Further comments
For now, I have successfully tested this with input containing * (asterisk) and _ (underscore) signs. It would be better if I could have more test cases.