Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: E2E Flag is not shown in the room parameters #5741

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Jun 12, 2024

Proposed changes

Corrects the logic of showing e2e on the room creation screen and also improves the code.

Issue(s)

How to test or reproduce

  • Go to server workspace administration
  • Go to settings
  • Go to "E2E Encryption"
  • Enable "E2E Encryption" and "Enable encryption for Private Rooms by default"
  • Save changes
  • Open the app on mobile
  • Create a new room
  • Skip adding participants

In the next screen, you should see room creation parameters, with the encryption flag turned off

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: CORE-94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant