Jc/sample app swiftui #3911
Open
Jc/sample app swiftui #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
nyeu
added
the
refactor
tonidero
reviewed
May 23, 2024
| /* Begin XCRemoteSwiftPackageReference section */ | ||
| 4E3BE8642BF77F420045B504 /* XCRemoteSwiftPackageReference "purchases-ios" */ = { | ||
| isa = XCRemoteSwiftPackageReference; | ||
| repositoryURL = "https://github.com/RevenueCat/purchases-ios"; |
There was a problem hiding this comment.
I think we want to change to use https://github.com/RevenueCat/purchases-ios-spm instead, since it's much faster. cc @jamesrb1
### Motivation Better implementation of #3909 and what was just commited to `5.0-dev` ### Description - Only install `swiftlint` on Xcode 15.3 jobs - Also moved Ruby 3.2.2 install into `install-bundle-dependencies` which was also done in `5.0-dev`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Apps were not showcasing the latest features and were outdated. This not only helps our customers to easily understand how RevenueCat features work but it's also helpful for when the DSE team has to debug something related to paywalls.
Description
I've run the app both through a simulator and a real device using my own app projects, subscribing and seeing the expected result.
Video showcasing both paywalls:
Simulator.Screen.Recording.-.iPhone.15.-.2024-05-27.at.15.18.03.mp4