[WIP] Shot-allocation through sampling for split_non_commuting
#5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
mlxd
reviewed
Jun 11, 2024
| ) | ||
|
|
||
| shots_list = [ | ||
| binom(n=rmng_shots, p=prob).rvs() for rmng_shots in remaining_shots_budget[idx] |
There was a problem hiding this comment.
Are we certain the values we put in here are always bounded between 0 and 1 (including numerical precision errors)?
| @@ -28,10 +31,22 @@ | |||
| from pennylane.typing import Result, ResultBatch | |||
|
|
|||
|
|
|||
| class ObsMetadata(NamedTuple): | |||
There was a problem hiding this comment.
Any advantage of using a NamedTuple vs a dataclass here?
trbromley
reviewed
Jun 13, 2024
| @transform | ||
| def split_non_commuting( | ||
| tape: qml.tape.QuantumScript, | ||
| grouping_strategy: Optional[str] = "default", | ||
| term_sampling: Optional[Literal["weighted", "uniform"]] = None, |
There was a problem hiding this comment.
Please can this term be included in the docs
… bug in post-processing function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: