Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .idea to .gitignore #1273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

audriu
Copy link

@audriu audriu commented May 17, 2024

Added ignoring of .idea/ folder as it should be ignored. There was an entry in .gitignore file but it was commented for some reason.

Pre-Submission Checklist (optional but appreciated):

  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

@KillianLucas
Copy link
Collaborator

Hi @audriu! I just want to make sure I understand why? Above that it says this:

For a more nuclear option (not recommended) you can uncomment the following to ignore the entire idea

I feel if they don't recommend it, we shouldn't do it. What do you think?

@audriu
Copy link
Author

audriu commented Jun 15, 2024

Well, that comment is just weird it includes the link to a template but does not include anything from it.
Usually, IDE configuration is not committed and I can see it is not committed to open-interpreter either.
Big projects just exclude IDE configurations completely like here: https://github.com/numpy/numpy/blob/main/.gitignore#L9
, https://github.com/pytorch/pytorch/blob/main/.gitignore#L227 , https://github.com/python/cpython/blob/main/.gitignore#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants