Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added batch, bat aliases for shell language #1242

Merged
merged 1 commit into from
May 4, 2024

Conversation

CyanideByte
Copy link
Contributor

@CyanideByte CyanideByte commented Apr 27, 2024

Describe the changes you have made:

  • Added aliases 'batch' and 'bat' to the shell language to match the linux/mac aliases.

Reference any relevant issues (e.g. "Fixes #000"):

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

Copy link
Collaborator

@Notnaton Notnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be under powershell.py ?

Batch and bat is for windows

@CyanideByte
Copy link
Contributor Author

CyanideByte commented Apr 30, 2024

Should be under powershell.py ?

Batch and bat is for windows

Batch scripts have always been running under shell through jupyter even without the aliases.
This is just to catch a few cases where models specifically mention batch or bat.
I think powershell is differentiated because its running in a separate process.
Jupyter might be able to run powershell as well I'm not sure, but also powershell can't run batch scripts directly.

@Notnaton Notnaton dismissed their stale review April 30, 2024 06:17

No problem then

@KillianLucas KillianLucas merged commit dcb96ca into OpenInterpreter:main May 4, 2024
0 of 2 checks passed
@KillianLucas
Copy link
Collaborator

Great work as always @CyanideByte and many thanks @Notnaton for reviewing! Merged.

@CyanideByte CyanideByte deleted the batch-alias branch May 4, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants