-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend/backend] In CSV Feed Ingester, take into account Default Marking definition options from CSV Mapper #7275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d33f71c
to
d113e63
Compare
opencti-platform/opencti-graphql/src/modules/ingestion/ingestion-csv.graphql
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-graphql/src/modules/ingestion/ingestion-csv.graphql
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-graphql/src/manager/ingestionManager.ts
Outdated
Show resolved
Hide resolved
903bcc5
to
c8d1ae7
Compare
f4684ab
to
c0ff113
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7275 +/- ##
==========================================
+ Coverage 67.34% 67.37% +0.02%
==========================================
Files 563 563
Lines 69680 69661 -19
Branches 5891 5887 -4
==========================================
+ Hits 46928 46935 +7
+ Misses 22752 22726 -26 ☔ View full report in Codecov by Sentry. |
9698bbd
to
566ba6d
Compare
...nt/src/private/components/analyses/external_references/ExternalReferenceFileImportViewer.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
Kedae
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
To test this feature, create CSV mappers with both options:
To set default markings:
you have to go to Customization > Entity types
![image](https://private-user-images.githubusercontent.com/13460700/337920260-33785f41-b675-41cf-861a-7eca14b33c31.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MDM4NDIsIm5iZiI6MTcxOTYwMzU0MiwicGF0aCI6Ii8xMzQ2MDcwMC8zMzc5MjAyNjAtMzM3ODVmNDEtYjY3NS00MWNmLTg2MWEtN2VjYTE0YjMzYzMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDE5MzkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZlYzM1NWM5MTBmMzBmMmJkOTM3ZmM3YjllMjFlNDlhYmM5NDQ4MWIxNDk3NTU0ZmFlNDJlMjc4OGFlMTFmOGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bZyzGtvMYOvQ4WY008YDSfdzG0HuRkX9cBLHtH9lSAI)
select an entity type
select the Marking attribute
![image](https://private-user-images.githubusercontent.com/13460700/337920353-5b95c6a7-57f7-4829-b2d2-954d27c41b02.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MDM4NDIsIm5iZiI6MTcxOTYwMzU0MiwicGF0aCI6Ii8xMzQ2MDcwMC8zMzc5MjAzNTMtNWI5NWM2YTctNTdmNy00ODI5LWIyZDItOTU0ZDI3YzQxYjAyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDE5MzkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAyMzE1Y2VlOTUzMzQ2YWQ2ZWQ5YjIwMTVlYmU4MjIxNzBjN2UxNThmZmU1MTY2MDdlZjliNjc5ZWYzMmI1MDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vecPTZbLmt90Zg3MRYkDv7ZolhKNJSB9fDxkHW12tI8)
activate default values
![image](https://private-user-images.githubusercontent.com/13460700/337920409-3099a992-f714-439e-835a-63423a474740.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MDM4NDIsIm5iZiI6MTcxOTYwMzU0MiwicGF0aCI6Ii8xMzQ2MDcwMC8zMzc5MjA0MDktMzA5OWE5OTItZjcxNC00MzllLTgzNWEtNjM0MjNhNDc0NzQwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDE5MzkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYyYTVlNjMyMmIyNmViMTQ2NmM1NGI4MWM1NzA2YWIwYjVlNzMwMDZiZDA4YjZmNGI5YmVmYWQ3MmZjN2Y1ZjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.z-h9Op2ysEYcGCPI4qJAA165hz8dH0azJU2yAjshGjc)
navigate to Security > Groups, select the current group (=> default)
![image](https://private-user-images.githubusercontent.com/13460700/337920492-37cd2165-753c-4117-9a64-dcdc6c4a90fb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MDM4NDIsIm5iZiI6MTcxOTYwMzU0MiwicGF0aCI6Ii8xMzQ2MDcwMC8zMzc5MjA0OTItMzdjZDIxNjUtNzUzYy00MTE3LTlhNjQtZGNkYzZjNGE5MGZiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDE5MzkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdhMjIyZjhiNTYyOWIwNWViY2RlMmViNzUwNmRmMzVkM2ZhNWIzMzA3YjAyNDEwOGY1M2M5NWU3YzE5MjQ2YmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WdMLvQ1OJORMJK56PFh7Tm7dAsgRGc5Q9COQuqAXZf0)
select allowed markings, so they can be added to the list of options for default markings
select default markings
![image](https://private-user-images.githubusercontent.com/13460700/337920523-d64672f7-1c37-477d-ad85-a2723b3279e3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MDM4NDIsIm5iZiI6MTcxOTYwMzU0MiwicGF0aCI6Ii8xMzQ2MDcwMC8zMzc5MjA1MjMtZDY0NjcyZjctMWMzNy00NzdkLWFkODUtYTI3MjNiMzI3OWUzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDE5MzkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg0M2Q5YjgyMDc3NmEyZWJkNGU5ZTczNmNjZDkzODQ3MTg3Zjk1NmVmZWUwODgxNmQ4NTc4N2E5NGRhMzMyNjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PhzaIRfmrGG4Vi-NozhwlKS-hf2M-BKI7rWhLWjoK3M)
Single column CSV file to test your CVS mapper:
6149-ipv4-addr.csv
Single column CSV feed to ingest IPv4 addresses: https://lists.blocklist.de/lists/all.txt
To check for the successful ingestion:
To check different use cases :