Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAB Replacement on container knowledge, entities, and observables tabs #7274

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Bonsai8863
Copy link
Contributor

@Bonsai8863 Bonsai8863 commented Jun 7, 2024

Proposed changes

  • Replaced FAB in Containers > Knowledge > Add Drawer
  • Replaced FAB in Containers > Entities
  • Replaced FAB in Containers > Observables

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@Bonsai8863 Bonsai8863 changed the title Feature/fab replacement/container entities observables FAB Replacement on container knowledge, entities, and observables tabs Jun 10, 2024
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/container_entities_observables branch from 36f3355 to 20e1107 Compare June 10, 2024 14:31
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/container_entities_observables branch from 20e1107 to aa0168e Compare June 14, 2024 13:20
@Bonsai8863 Bonsai8863 marked this pull request as ready for review June 14, 2024 13:20
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.72%. Comparing base (4c020e0) to head (49d870c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7274   +/-   ##
=======================================
  Coverage   67.72%   67.72%           
=======================================
  Files         561      561           
  Lines       68985    68985           
  Branches     5875     5875           
=======================================
  Hits        46718    46718           
  Misses      22267    22267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kedae Kedae added the community use to identify PR from community label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants