Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Bulk create relationship in container context (#7443) #7242

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Jun 5, 2024

Proposed changes

UNDER FEATURE FLAG: 4352_BULK_RELATIONS

  • Add a new dialog in the knowledge tab of Intrusion-Set (other places in platform to come in follow up PRs)
  • Allow to create relations to SCO and SDO that already exists in the patform and matches the relation type.

Everything is done in frontend as per brainstorm descision.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@aHenryJard aHenryJard changed the title Issue/4352 bulk entities Bulk create relationship in container context (#4352) Jun 6, 2024
@aHenryJard aHenryJard linked an issue Jun 6, 2024 that may be closed by this pull request
@aHenryJard aHenryJard changed the title Bulk create relationship in container context (#4352) [frontend] Bulk create relationship in container context (#4352) Jun 6, 2024
@aHenryJard aHenryJard self-assigned this Jun 6, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran force-pushed the issue/4352-bulk-entities branch 2 times, most recently from 45783a0 to d465ab8 Compare June 17, 2024 12:05
@ValentinBouzinFiligran ValentinBouzinFiligran marked this pull request as ready for review June 21, 2024 14:00
@aHenryJard aHenryJard changed the title [frontend] Bulk create relationship in container context (#4352) [frontend] Bulk create relationship in container context (#7443) Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (af5f572) to head (782a1b7).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7242      +/-   ##
==========================================
+ Coverage   67.53%   67.59%   +0.05%     
==========================================
  Files         567      567              
  Lines       69843    69903      +60     
  Branches     5933     5981      +48     
==========================================
+ Hits        47170    47252      +82     
+ Misses      22673    22651      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jun 27, 2024
@SouadHadjiat
Copy link
Member

SouadHadjiat commented Jun 28, 2024

Testing review

  • Missing some SDO (all SDO should be available for related to relationships)
  • Relationship types are only available in one direction (from intrusion set), we don't have the other direction relations => Not included in this POC

@SouadHadjiat SouadHadjiat marked this pull request as draft June 28, 2024 14:49
@SouadHadjiat SouadHadjiat marked this pull request as ready for review June 28, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POC on Bulk creation of SDO/SCO with Copy/Pasting: bulk create relationship
4 participants